Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(fe:FSADT1-1521): create the predictive search #1223

Merged
merged 23 commits into from
Oct 10, 2024
Merged

feat(fe:FSADT1-1521): create the predictive search #1223

merged 23 commits into from
Oct 10, 2024

Conversation

fterra-encora
Copy link
Collaborator

@fterra-encora fterra-encora commented Oct 8, 2024 •
edited by github-actions bot
Loading

Description

  • Adds the search box;
  • displays the predictive search results on it;
  • opens the Client details in a new tab.

Fixes FSADT1-1521

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation update

How Has This Been Tested?

  • New unit tests
  • New integrated tests
  • New component tests
  • New end-to-end tests
  • New user flow tests
  • No new tests are required
  • Manual tests (description below)
  • Updated existing tests

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

Thanks for the PR!

Deployments, as required, will be available below:
Any successful deployments (not always required) will be available here

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

Thanks for the PR!

Deployments, as required, will be available below:
Any successful deployments (not always required) will be available here

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024 •
edited
Loading

Current changelog

Bug Fixes

  • fix predictive-search stubs (80e469c)
  • rename event from click to click:option (f46f681)
  • use placeholder instead of label (2dd07a2)

Features

  • add search box with predictive search (24b827f)
  • be:FSADT1-1519: Create API endpoint for predictive search (8ca00b1)
  • be:FSADT1-1519: Create API endpoint for predictive search (3b2941c)
  • be:FSADT1-1519: Create API endpoint for predictive search (b467da6)
  • fe:FSADT1-1541: Display an error message when the BE is down (#1227) (c2c09fe)
  • fe:FSADT1-1541: Display an error message when the BE is down (#1227) (7127d58)
  • FSADT1-1519: Draft for Create API endpoint for predictive search (1187889)
  • FSADT1-1519: Predictive search #2 (b4b34c3)
  • FSADT1-1519: Predictive search endpoint #1 (cc6f1b2)
  • navigate to client details (7fdffcf)
  • open client details in a new tab (a6d44d2)
  • prevent selection on AutoComplete (a6a3234)
  • update style of search controls (0126363)
  • validate autocomplete while typing (1e7dbd2)
  • validate keywords (fb567c9)

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@fterra-encora fterra-encora merged commit 258ed26 into feat/client3 Oct 10, 2024
26 checks passed
@fterra-encora fterra-encora deleted the feat/FSADT1-1521 branch October 10, 2024 14:23
@github-actions github-actions bot mentioned this pull request Oct 10, 2024
Merged
@fterra-encora fterra-encora mentioned this pull request Oct 10, 2024
Merged
21 tasks
@github-actions github-actions bot mentioned this pull request Oct 16, 2024
Merged
21 tasks
fterra-encora added a commit that referenced this pull request Oct 17, 2024
@fterra-encora @mamartinezmejia
feat(fe:FSADT1-1522): Create full search (data table) (#1244)
a9fa926 
* feat(FSADT1-1519): Draft for Create API endpoint for predictive search

* Added temporary feature flag for the search functionality

* feat(FSADT1-1519): Predictive search endpoint #1

* feat(FSADT1-1519): Predictive search #2

* feat(be:FSADT1-1519): Create API endpoint for predictive search

* feat(be:FSADT1-1519): Create API endpoint for predictive search

* chore: Added javadocs

* Removed unused imports

* feat(be:FSADT1-1519): Create API endpoint for predictive search

* Refactored code and included full seach

* Refactored code to have 1 query only

* Added count in the API

* feat(fe:FSADT1-1541): Display an error message when the BE is down (#1227)

* feat(fe:FSADT1-1521): create the predictive search (#1223)

* feat: add search box with predictive search

* fix: fix predictive-search stubs

* feat: update style of search controls

* docs: update interface name

* fix: use placeholder instead of label

* test: add search test file

* feat: navigate to client details

* test: implement tests

* refactor: move functions to the GlobalValidators

* feat: validate autocomplete while typing

* feat: validate keywords

* test: validate keywords

* feat: prevent selection on AutoComplete

* feat: open client details in a new tab

* chore: update endpoint stub

* test: update tests

* feat(fe:FSADT1-1541): Display an error message when the BE is down (#1227)

* fix: rename event from click to click:option

---------

Co-authored-by: Maria Martinez <[email protected]>

* Renamed files

* Added missing key

* fix(fe:FSADT1-1521): clear the AutoComplete field when preventSelection is true (#1230)

* test: fix tests

* fix: do not prevent the clearing action

* Added stubs for full search

* fix: apply the feature flag to the Client search button

And remove it from the check of user's authority.

* chore: add header x-total-count to stub

* feat: add css tag colors from nr-theme

* feat: set status tag colors

* fix: prevent emitting the full css theme

* feat: emit press:enter

* fix: prevent emitting press:enter when it's a selection

* feat: update full search behavior

* feat: prevent search with invalid value

* fix: reset error message

* fix: remove optional from validations

* chore: update stub file

* fix: display empty acronyms

Also sets column widths

* test: check results by index

* fix: fix displaying issue on status column

Also updates css class names

* test: add more tests

* fix: allow empty search

* test: search with no keywords

---------

Co-authored-by: Maria Martinez <[email protected]>
Co-authored-by: Maria Martinez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulushcgcj paulushcgcj paulushcgcj approved these changes

@mamartinezmejia mamartinezmejia Awaiting requested review from mamartinezmejia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fterra-encora @paulushcgcj @mamartinezmejia